Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new araic courses #6837

Merged

Conversation

AhmedElTabarani
Copy link
Contributor

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@AhmedElTabarani AhmedElTabarani force-pushed the add-new-arabic-courses branch from a19147d to 44eb0b7 Compare April 30, 2022 19:59
@AhmedElTabarani

This comment was marked as resolved.

@AhmedElTabarani

This comment was marked as resolved.

@AhmedElTabarani

This comment was marked as resolved.

@davorpa
Copy link
Member

davorpa commented Apr 30, 2022

also i notice some error here in RTL we must put \ after | like this |\

Screenshot 2022-04-30 222028

image

\| not is for render. it's for Markdown escape pipe. See bug #6723, #5176. So | should only be rendered

@davorpa
Copy link
Member

davorpa commented Apr 30, 2022

I don't think this mistake check is right

* [ReactJS Part 3 - Performance Optimization (react memo, use memo, use call back) [تعلم الرياكت] [الجزء الثالث]](https://www.youtube.com/playlist?list=PLejc1JbD4ZFTYdkjzqYBujf7UCVQyn_aq) - kimz codes
* [ReactJs-Build Full E-Commerce From Scratch Redux (بالعربي)](https://www.youtube.com/playlist?list=PLDQ11FgmbqQPRui5VDCSQvYt2HOYiCVep) - Programming Solutions - Academy

S is lower than s

I also try to sort all the React courses and it gives me the same order of mine

image

Alphabetization is much more than a merelly Array.sort(). The remark plugin strip some characters, is case insensitive and use Collators to sort the result according to natural language. See https://github.com/vhf/remark-lint-alphabetize-lists

@davorpa davorpa added linter error Please, correct build errors found by linter! 🗣️ locale:ar Resources addressing "Arabic / العربية" language labels Apr 30, 2022
@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Apr 30, 2022

See https://github.com/vhf/remark-lint-alphabetize-lists

I install it and run remark -u lint -u lint-alphabetize-lists courses\free-courses-ar.md

the output in the terminal is more than the PR lint checking

image

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Apr 30, 2022

ok I take the function that normalize the text from here and try it with sort, and it gives me the right order

image

@davorpa davorpa removed the linter error Please, correct build errors found by linter! label May 1, 2022
davorpa added a commit to davorpa/free-programming-books that referenced this pull request May 1, 2022
@davorpa
Copy link
Member

davorpa commented May 1, 2022

ok I take the function that normalize the text from here and try it with sort, and it gives me the right order

image

Nice minitool to quickly sort fpb resources. Thanks

@davorpa davorpa self-requested a review May 1, 2022 08:33
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AhmedElTabarani AhmedElTabarani force-pushed the add-new-arabic-courses branch from 7059b14 to 30b8798 Compare May 1, 2022 15:34
davorpa added a commit to davorpa/free-programming-books that referenced this pull request May 1, 2022
@davorpa davorpa closed this May 1, 2022
@davorpa davorpa reopened this May 1, 2022
@davorpa davorpa self-requested a review May 1, 2022 17:06
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label May 1, 2022
@eshellman
Copy link
Collaborator

thanks, everyone

@eshellman eshellman merged commit 2c5d677 into EbookFoundation:main May 2, 2022
@AhmedElTabarani AhmedElTabarani deleted the add-new-arabic-courses branch July 28, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:ar Resources addressing "Arabic / العربية" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants